Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace git command in gemspec #1055

Closed
utkarsh2102 opened this issue Sep 13, 2020 · 1 comment · Fixed by #1092
Closed

Replace git command in gemspec #1055

utkarsh2102 opened this issue Sep 13, 2020 · 1 comment · Fixed by #1092

Comments

@utkarsh2102
Copy link

Hello @composerinteralia 👋🏻

Thanks for your great work here and elsewhere! ❤️

Whilst maintaining this in Debian, I found that this library relies on git to produce a list of files.

suspenders/suspenders.gemspec

Line 20 in f16e743

s.files = `git ls-files`.split("\n")

Using git in gemspec is a bit problematic and it's best if avoided. More about this can be found here:
https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale

I'd be happy to submit a PR if you concur with this?
@composerinteralia
Copy link
Contributor

Thanks for the kind words. Yeah, I'd be open to moving away from git ls-file. We use Dir.glob over on factory_bot, so I assume we could do something similar here.

@utkarsh2102 utkarsh2102 mentioned this issue Sep 26, 2020
Closed
@thiagoa thiagoa changed the title Drop git in gemspec Replace git command in gemspec Oct 1, 2021
thiagoa added a commit that referenced this issue May 6, 2022
@thiagoa
Drop use of git in gemspec
2183be3 
Closes #1055
@thiagoa thiagoa mentioned this issue May 6, 2022
Merged
thiagoa added a commit that referenced this issue May 6, 2022
@thiagoa
Drop use of git in gemspec
1f362bc 
Closes #1055
thiagoa added a commit that referenced this issue May 6, 2022
@thiagoa
Drop use of git in gemspec
1d106e8 
Closes #1055
thiagoa added a commit that referenced this issue May 6, 2022
@thiagoa
Drop use of git in gemspec
29384a9 
Closes #1055

Changes `suspenders.gemspec` to not depend on git. Additionally, we
can safely remove `s.test_files` since its use is no longer
recommended and was introduced in the Suspenders codebase many years
ago.

References: rubygems/guides#90
thiagoa added a commit that referenced this issue May 6, 2022
@thiagoa
Drop use of git in gemspec
456617f 
Closes #1055

Changes `suspenders.gemspec` to not depend on git. Additionally, we
can safely remove `s.test_files` since its use is no longer
recommended and was introduced in the Suspenders codebase many years
ago.

References: rubygems/guides#90
Web-Go-To added a commit to Web-Go-To/rails_suspenders that referenced this issue Mar 23, 2023
@Web-Go-To
Drop use of git in gemspec
27f410c 
Closes thoughtbot/suspenders#1055

Changes `suspenders.gemspec` to not depend on git. Additionally, we
can safely remove `s.test_files` since its use is no longer
recommended and was introduced in the Suspenders codebase many years
ago.

References: rubygems/guides#90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop use of git in gemspec thoughtbot/suspenders
3 participants
@thiagoa @composerinteralia @utkarsh2102