Drop use of git in gemspec #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thiagoa
force-pushed
the
drop-use-of-git-in-gemspec
branch
2 times, most recently
from
1f362bc
to
1d106e8
Compare
|
I'm merging this PR since it's basically the feedback that was asked in #1057 + I noticed |
Closes #1055 Changes `suspenders.gemspec` to not depend on git. Additionally, we can safely remove `s.test_files` since its use is no longer recommended and was introduced in the Suspenders codebase many years ago. References: rubygems/guides#90
thiagoa
force-pushed
the
drop-use-of-git-in-gemspec
branch
from
1d106e8
to
29384a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1055
Changes
suspenders.gemspecto not depend on git. Additionally, we can safely removes.test_filessince its use is no longer recommended and was introduced in the Suspenders codebase many years ago.