Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Email' in profile manager when creating account. #2066

Closed
AlaaElattar opened this issue Jan 24, 2024 · 7 comments
Closed

Add 'Email' in profile manager when creating account. #2066

AlaaElattar opened this issue Jan 24, 2024 · 7 comments
Assignees
Labels
type_feature New feature or request
Milestone

Comments

@AlaaElattar
Copy link
Contributor

Description

  • The user will also save its email and should be saved in the metadata.
@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Jan 24, 2024
@ramezsaeed ramezsaeed added the type_feature New feature or request label Jan 24, 2024
@samaradel samaradel self-assigned this Feb 12, 2024
@samaradel samaradel moved this to In Progress in 3.14.x Feb 12, 2024
@samaradel
Copy link
Contributor

WIP:
Email added in creating account tab and in profile manager but still investigating to get the value of email

@samaradel
Copy link
Contributor

WIP:
Email is working fine in the profile manager, now working on adding email in profile page

@samaradel samaradel mentioned this issue Feb 14, 2024
5 tasks
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Feb 14, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.14.x Feb 18, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Feb 18, 2024
@samaradel samaradel moved this from Pending Review to Accepted in 3.14.x Feb 20, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x Feb 20, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Feb 20, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.14.x Feb 22, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Feb 22, 2024
@samaradel samaradel moved this from Pending Review to Accepted in 3.14.x Feb 22, 2024
@samaradel samaradel moved this from Accepted to Pending Review in 3.14.x Feb 22, 2024
@samaradel
Copy link
Contributor

Work Completed:

  • Email saved in metadata and added to (connect your wallet, your profile, and TFChain Wallet)
  • it can be added/edited in your profile page

@samaradel samaradel moved this from Pending Review to In Verification in 3.14.x Feb 25, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
version : ac5cd85
adding email and editing it is now available when creating an account and also in my profile page you can edit or add an email.

Image
Image
Image
Image
Image
Image

https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422331#case_4150327
https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422331#case_4246385

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Mar 24, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Mar 24, 2024

When validating a mnemonic or creating a new account, all the inputs are disabled except for the email.

image

@A-Harby A-Harby moved this from Done to Accepted in 3.14.x Mar 24, 2024
@samaradel
Copy link
Contributor

Done on #2506

@samaradel samaradel moved this from Accepted to In Verification in 3.14.x Mar 27, 2024
@A-Harby A-Harby moved this from In Verification to Pending Review in 3.14.x Apr 1, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.14.x Apr 14, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Apr 14, 2024

Verified, Devnet f3e199e.

image
image

#2066 (comment)

And I found an issue reported here:#2555.

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants