Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email input #2165

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Add email input #2165

merged 4 commits into from
Feb 25, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Feb 14, 2024 •
edited
Loading

Description

Add email input to

  • connect your wallet tab
  • your profile page
  • TfChain wallet dialog

Changes

Screencast.from.22-02-24.13.22.39.webm

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Add email input to
e56dea7 
- connect your wallet tab
- your profile page
TfChain wallet dialog
zaelgohary
zaelgohary reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samaradel Good job. Just one comment. Some solutions use email input in its form. Maybe we should set the default email value to the user email? What do you think?

@samaradel
Copy link
Contributor Author

@samaradel Good job. Just one comment. Some solutions use email input in its form. Maybe we should set the default email value to the user email? What do you think?

Awesome, totally agree

@samaradel samaradel marked this pull request as draft February 18, 2024 09:01
@samaradel samaradel mentioned this pull request Feb 18, 2024
Closed
@samaradel samaradel marked this pull request as ready for review February 18, 2024 10:09
@AhmedHanafy725 AhmedHanafy725 changed the base branch from development to development_314 February 18, 2024 13:53
@samaradel samaradel requested a review from zaelgohary February 19, 2024 09:00
amiraabouhadid
amiraabouhadid requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make email field responsive in profile page
image

@samaradel samaradel marked this pull request as draft February 20, 2024 09:44
@samaradel
Copy link
Contributor Author

@amiraabouhadid fixed

image

@samaradel samaradel marked this pull request as ready for review February 20, 2024 11:40
@AlaaElattar
Copy link
Contributor

AlaaElattar commented Feb 21, 2024 •
edited
Loading

  • Why it requests to refresh, when i wanted to add my email ?
Screencast.from.02-21-2024.01.07.35.PM.webm

@AlaaElattar
Copy link
Contributor

  • The connect button took long time to start reloading.
  • Also updating the email took long time.
Screencast.from.02-21-2024.01.11.25.PM.webm

@AlaaElattar
Copy link
Contributor

  • Why this is happened when i wanted to login again !!
Screencast.from.02-21-2024.01.18.46.PM.webm

@samaradel samaradel marked this pull request as draft February 22, 2024 09:30
@samaradel samaradel marked this pull request as ready for review February 22, 2024 11:29
@samaradel
Copy link
Contributor Author

@AlaaElattar fixed

@MohamedElmdary
Copy link
Member

@samaradel Can we disable save btn while saving user's email as reclicking it will duplicate logic

@samaradel samaradel marked this pull request as draft February 22, 2024 13:29
@samaradel samaradel marked this pull request as ready for review February 22, 2024 14:34
@samaradel
Copy link
Contributor Author

@samaradel Can we disable save btn while saving user's email as reclicking it will duplicate logic

fixed

@AlaaElattar
Copy link
Contributor

@samaradel Good job. Just one comment. Some solutions use email input in its form. Maybe we should set the default email value to the user email? What do you think?

This comment is not applied yet

@samaradel
Copy link
Contributor Author

@samaradel Good job. Just one comment. Some solutions use email input in its form. Maybe we should set the default email value to the user email? What do you think?

This comment is not applied yet

created an issue for this #2188

@samaradel samaradel merged commit 427e275 into development_314 Feb 25, 2024
3 checks passed
@samaradel samaradel deleted the development_profile_email branch February 25, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@0oM4R 0oM4R Awaiting requested review from 0oM4R

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samaradel @AlaaElattar @MohamedElmdary @zaelgohary @amiraabouhadid