Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy way to delete range/set of IPs #2561

Closed
sameh-farouk opened this issue Apr 15, 2024 · 11 comments
Closed

Easy way to delete range/set of IPs #2561

sameh-farouk opened this issue Apr 15, 2024 · 11 comments
Assignees
Labels
dashboard type_feature New feature or request
Milestone

Comments

@sameh-farouk
Copy link
Member

Which package/s are you suggesting this feature for?

Dashboard

Is your feature request related to a problem? Please describe

Dashboard allows you to add a range of IPs. Would it be possible to allow the selection of a set of IPs for deletion instead of going through them one by one?
I understand that this task may not be an everyday one, but making it easier will help users appreciate the flawlessness when it comes time to use it.

Describe the solution you'd like

I think adding a standard checkbox for every IP and allowing one to select/deselect all checkboxes would be a nice UX improvement.
Screenshot_20240415_155418

@sameh-farouk sameh-farouk added type_feature New feature or request dashboard labels Apr 15, 2024
@xmonader xmonader added this to 3.14.x Apr 16, 2024
@xmonader xmonader moved this to Accepted in 3.14.x Apr 16, 2024
@xmonader xmonader added this to the 2.5.0 milestone Apr 16, 2024
@samaradel samaradel self-assigned this Apr 21, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x Apr 21, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to In Verification in 3.14.x Apr 21, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from In Verification to In Progress in 3.14.x Apr 21, 2024
@samaradel
Copy link
Contributor

Work Completed:

Remove the delete button and add delete all action

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Apr 21, 2024
@samaradel samaradel moved this from Pending Review to Accepted in 3.14.x Apr 22, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x Apr 23, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Apr 23, 2024
@samaradel
Copy link
Contributor

Work Completed:

Some code enhancement as per pull request comments

@samaradel samaradel moved this from Pending Review to In Progress in 3.14.x Apr 24, 2024
@samaradel
Copy link
Contributor

Work Completed:
Create removeFarmIps function to delete all ips in one action

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x Apr 24, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.14.x Apr 29, 2024
@samaradel
Copy link
Contributor

Work in Progress (WIP):

Working on PR comment

@samaradel
Copy link
Contributor

Work in Progress (WIP):

faced some issues while build , still investigating ..

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 2, 2024
@samaradel
Copy link
Contributor

samaradel commented May 2, 2024

Work Completed:

Add removeFarmIps method in tf grid

@samaradel samaradel moved this from Pending Review to In Progress in 3.14.x May 9, 2024
@samaradel
Copy link
Contributor

Work Completed:

  • Document removeFarmIps methods.

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 9, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.14.x May 13, 2024
@A-Harby
Copy link
Contributor

A-Harby commented May 15, 2024

#2610 (comment)

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x May 15, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x May 15, 2024
@samaradel
Copy link
Contributor

Work in Progress (WIP):

investigating..

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 16, 2024
@samaradel
Copy link
Contributor

Work Completed:

Fix farms public IPs table selection by removing the current data-table and passing props to list-table component.

@amiraabouhadid amiraabouhadid moved this from Pending Review to In Verification in 3.14.x May 19, 2024
@khaledyoussef24
Copy link
Contributor

khaledyoussef24 commented May 21, 2024

verified on devnet
version : 85a6fa4
a standard check box is now added to the ip table to make deleting a contract or multiple contracts easier

Image

test case

@khaledyoussef24 khaledyoussef24 removed the status in 3.14.x May 21, 2024
@khaledyoussef24 khaledyoussef24 moved this to Done in 3.14.x May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

6 participants