Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove farms public IP delete button and create delete all action with it's module and method #2593

Merged
merged 9 commits into from
May 13, 2024
Merged

Remove farms public IP delete button and create delete all action with it's module and method #2593

merged 9 commits into from
May 13, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Apr 21, 2024 •
edited
Loading

Description

  • Remove the delete button and add delete all action.
  • Create removeFarmIps module.
  • Create removeFarmIps method in tf-grid.
  • Document removeFarmIps methods.

Changes

Screencast.from.21-04-24.17.17.26.webm

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
Copy link
Contributor

Does the loader color want to be red?
image

Mahmoud-Emad
Mahmoud-Emad requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Samar!

packages/playground/src/dashboard/components/public_ips_table.vue Outdated Show resolved Hide resolved
packages/playground/src/dashboard/components/public_ips_table.vue Outdated Show resolved Hide resolved
packages/playground/src/dashboard/components/public_ips_table.vue Outdated Show resolved Hide resolved
@samaradel samaradel marked this pull request as draft April 22, 2024 08:32
@samaradel samaradel marked this pull request as ready for review April 23, 2024 11:35
@samaradel samaradel requested a review from Mahmoud-Emad April 23, 2024 11:36
@samaradel samaradel marked this pull request as draft April 24, 2024 08:07
@samaradel samaradel marked this pull request as ready for review April 24, 2024 16:09
@samaradel samaradel marked this pull request as draft April 29, 2024 13:31
@samaradel samaradel marked this pull request as ready for review May 2, 2024 11:44
@samaradel samaradel mentioned this pull request May 2, 2024
Closed
1 task
@samaradel samaradel requested review from AhmedHanafy725 and 0oM4R May 2, 2024 11:47
@samaradel samaradel changed the title Remove delete button Remove delete button and create delete all action with it's module and method May 2, 2024
@samaradel samaradel changed the title Remove delete button and create delete all action with it's module and method Remove farms public IP delete button and create delete all action with it's module and method May 2, 2024
Base automatically changed from development_2.5 to development May 7, 2024 12:16
An error occurred while trying to automatically change base from development_2.5 to development May 7, 2024 12:16
Mahmoud-Emad
Mahmoud-Emad requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

packages/grid_client/src/clients/tf-grid/farms.ts Outdated Show resolved Hide resolved
packages/grid_client/src/modules/farms.ts Outdated Show resolved Hide resolved
@samaradel samaradel marked this pull request as draft May 9, 2024 09:18
@samaradel samaradel marked this pull request as ready for review May 9, 2024 09:39
@samaradel samaradel requested a review from Mahmoud-Emad May 9, 2024 10:00
Mahmoud-Emad
Mahmoud-Emad approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Samar

@0oM4R 0oM4R dismissed their stale review May 13, 2024 09:33

outdated

@samaradel samaradel merged commit 4d7e369 into development May 13, 2024
3 checks passed
@samaradel samaradel deleted the development_2.5_publicips_table branch May 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samaradel @Mahmoud-Emad @zaelgohary @AhmedHanafy725 @0oM4R