Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Delete IPs should be reflected on the farm IPs table #2610

Closed
1 task done
A-Harby opened this issue Apr 25, 2024 · 6 comments
Closed
1 task done

🐞 [Bug]: Delete IPs should be reflected on the farm IPs table #2610

A-Harby opened this issue Apr 25, 2024 · 6 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Apr 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

Deleting the IPs from a farm isn't applied to the table until a refresh, not like adding, which is applied instantly.

Steps To Reproduce

  1. Navigate to the Dashboard.
  2. Connect your account.
  3. Navigate to your farm page.
  4. Create a farm.
  5. Add IP to it.
  6. Delete that IP (it will not be gone without a refresh).
  7. You could delete it again, and it will give an error.

which network/s did you face the problem on?

Dev

version

e7030e6

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

screen-capture.30.webm

Relevant log output

.
@A-Harby A-Harby added the type_bug Something isn't working label Apr 25, 2024
@ramezsaeed ramezsaeed added this to 3.14.x May 1, 2024
@ramezsaeed ramezsaeed added this to the 2.5.0 milestone May 1, 2024
@Mahmoud-Emad
Copy link
Contributor

#2561 should solve this one

@Mahmoud-Emad Mahmoud-Emad moved this to In Progress in 3.14.x May 1, 2024
@Mahmoud-Emad
Copy link
Contributor

What is the status here?

@samaradel
Copy link
Contributor

samaradel commented May 2, 2024

Work Completed:

resolved with #2593

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 2, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.14.x May 13, 2024
@A-Harby
Copy link
Contributor Author

A-Harby commented May 15, 2024

Devnet, 71a3b1a.

The selection isn't working correctly, it select/unselect all.
and the deletion is failing.

screen-capture.2.webm

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x May 15, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x May 15, 2024
@samaradel
Copy link
Contributor

related to #2561

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 16, 2024
@amiraabouhadid amiraabouhadid moved this from Pending Review to In Verification in 3.14.x May 19, 2024
@A-Harby
Copy link
Contributor Author

A-Harby commented Jun 3, 2024

Verified, Devnet 17d861b.

The IP deletion is now working fine with selection one or more IP, and it's reflected instantly on the table.

screen-capture.8.webm

TC2209 - Delete IP

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants