Improve node selector details #1884
Conversation
- feat: add NodeDetailsCard showing more details in node selector - refactor: use node card in node selector - refactor: turn node selector into VSelect instead of VAutocomplete
…nt with same functions
- style: turn VAlert into elevated variant instead of tonal
MohamedElmdary
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
Mahmoud-Emad,
amiraabouhadid,
Omarabdul3ziz,
AlaaElattar and
0oM4R
as code owners
|
i think the separator between cards should be stronger to be clear. what do u think ? |
VDivider style doesn't match with outer border so I added a border bottom instead |
There was a problem hiding this comment.
- After the nodes are loaded it randomly scrolls to one of the nodes, i think it should load the nodes and leave it up to the user to select the desired node.
Screencast.from.08-01-24.15.54.16.webm
-
I believe as it was agreed upon before that the user doesn't need to know anything about the term storage pools and it would be better if the message was updated to something else like "checking if the deployment will fit in the node's disks" or something similar.
-
IMO it would look better if the node id was written in the same way as the farm id. e.g. "Node ID: 11" instead of using brackets.
-
In the manual filter, when the dedicated node filter is enabled and a shared node id is added it should mention that this node is shared in the error message instead of mentioning that this node is not rented.
-
On mainnet, some nodes appeared without flag. e.g. node 2336
even though the node has a country in its details from the gridproxy
-
After Loading more nodes the storage pools check is done even when the same node is selected.
Screencast.from.08-01-24.16.40.48.webm
For farmName we need extra request |
It was a requested feature to improve ux |
- fix: Temp fix for *czechia* country by adding if condition for it - chore: open issue for that temp fix on tfchain_graphql#148 - style: Change how we show Node ID title - typo: Update messages to be more user friendly
This issue is still present |
It's verify that node still valid |
| " | ||
| /> | ||
| </div> | ||
| <!-- <div class="border-b" :style="{ borderBottomWidth: '2px !important' }" /> --> |
There was a problem hiding this comment.
remove the commented line
Description
Improve node selector details
Changes
Related Issues
SS
Initial Loading (loading while there is no loaded nodes yet)
After first loading pick a valid node and scroll down to that node (to it's center) smoothly
Show load more nodes (if there is more nodes to load)
Ask to reload node if data changed
Show error if the provided filters is not valid
Show message while validating
Show loading linear line (if loading and there is nodes already there)
Got hint as before
Has hint to notify user that cpu might be more than 100% (usage)
some more tooltips for more details
Deploy button disabled
Checklist