-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve node selector details #1884
Merged
xmonader
merged 12 commits into
development
from
development_improve_node_selector_details
Jan 10, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a0d5775
- feat: add serialNumber field in NodeInfo type
MohamedElmdary 65c274f
feat: rewrite node-selector (VSelect part) into a table alike compone…
MohamedElmdary 9ba43bf
- fix: limit scroll to 1 time per reload to not confuse the users
MohamedElmdary afd2b74
fix: move load more button to nodes container
MohamedElmdary e754ec7
feat: add error handling in validation & use detailsCard in manual no…
MohamedElmdary aa5ce21
fix: typo in node details card
MohamedElmdary 080fd3a
style: improve ui/ux for new node details card in node selector
MohamedElmdary 8a8db3d
style: remove details node card in manual if no node is selected
MohamedElmdary 9a0c78a
fix: set value to undefined when nodeId is changed
MohamedElmdary 3ee051f
fix: remove Node Serial Number if it's 'default string'
MohamedElmdary f04b4a9
Merge branch 'development' into development_improve_node_selector_det…
MohamedElmdary 612e9db
- feat: Add *dedicated* prop in **NodeInfo** type in grid_client
MohamedElmdary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the commented line