Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From another author #13

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

From another author #13

wants to merge 24 commits into from

Conversation

saravana-thiyagaraj
Copy link
Collaborator

No description provided.

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Comment on lines +3 to +5
on:
push:
branches: [ main ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerequesting..

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Copy link
Owner

@thsaravana thsaravana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try somethin new?

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Comment on lines +3 to +5
on:
push:
branches: [ main ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerequesting..

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Comment on lines +12 to +16
- uses: actions/checkout@v2
- name: Set up JDK 1.8
uses: actions/setup-java@v1
with:
java-version: 1.8
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need JDK setup?

@@ -1,11 +1,15 @@
package com.madrapps.jacoco.operation;

public class StringOp {
import com.madrapps.jacoco.StringOperation;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we run this through Detekt?

interface MathOp {

}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a new line to this?

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Copy link
Owner

@thsaravana thsaravana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try something new.

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Copy link
Owner

@thsaravana thsaravana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if you send this for a re-review.

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Copy link
Collaborator

@instrap instrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not up to mark. Check if everything works.

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@thsaravana thsaravana self-requested a review April 30, 2021 18:35
@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@github-actions github-actions bot requested a review from instrap April 30, 2021 18:42
@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

@github-actions
Copy link

File Coverage [78.95%] 🍏
StringOp.java 100% 🍏
Math.kt 70.37% 🍏
Total Project Coverage 45.45% 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants