-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From another author #13
base: main
Are you sure you want to change the base?
Changes from 18 commits
7bf416e
dc736a9
afeb2df
7b4da8b
58f3f23
46959ef
edc9d41
f0db3e9
3bff9f5
8bbd6ad
8830ef6
3177af8
c47e6ef
f40c6ad
ca1e4f4
447c386
11a6883
d6090c8
dceadc4
22ed8bb
db64118
04a3718
1d86dae
6be23cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
name: Add Requester | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
pull_request: | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up JDK 1.8 | ||
uses: actions/setup-java@v1 | ||
with: | ||
java-version: 1.8 | ||
Comment on lines
+12
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this need JDK setup? |
||
|
||
- name: Grant execute permission for gradlew | ||
run: chmod +x gradlew | ||
|
||
- name: Add Reviewers | ||
uses: madrapps/add-reviewers@main | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
reviewers: instrap,muralikrish91,thsaravana,saravana-thiyagaraj | ||
debug-mode: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.madrapps.jacoco; | ||
|
||
public interface StringOperation { | ||
boolean endsWith(String source, String chars); | ||
|
||
boolean startsWith(String source, String chars); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
package com.madrapps.jacoco.operation; | ||
|
||
public class StringOp { | ||
import com.madrapps.jacoco.StringOperation; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have we run this through Detekt? |
||
|
||
public class StringOp implements StringOperation { | ||
|
||
@Override | ||
public boolean endsWith(String source, String chars) { | ||
return source.endsWith(chars); | ||
} | ||
|
||
@Override | ||
public boolean startsWith(String source, String chars) { | ||
return source.startsWith(chars); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.madrapps.jacoco | ||
|
||
interface MathOperation { | ||
fun add(a: Int, b: Int): Int | ||
fun subtract(a: Int, b: Int): Int | ||
fun multiply(a: Int, b: Int): Int | ||
fun divide(a: Int, b: Int): Int | ||
|
||
interface MathOp { | ||
|
||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add a new line to this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rerequesting..