Skip to content

Commit

Permalink
Add support for displaying user comment origin instance (#944)
Browse files Browse the repository at this point in the history
* add support for displaying comment origin instance

* update changelog

* fix formatting on merge.

* rm unused, update instance messgae.

* fix comment show user instance reviews

renamed showOriginIntance to commentShowUserInstance,fix typos,fix Richtext text scaling

* fix commentShowUserInstance l10n
  • Loading branch information
ggichure authored Dec 9, 2023
1 parent ed76ad2 commit fe2a91c
Show file tree
Hide file tree
Showing 8 changed files with 194 additions and 81 deletions.
61 changes: 60 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Unreleased

## Added

- Added ability to collapse post in post page
- Added ability to change app language in settings
- Added ability to show/hide read posts in user settings
Expand All @@ -10,23 +11,29 @@
- Added setting to show/hide bot content
- Added the ability to render SVGs in markdown bodies - contribution from @micahmo
- Added Safari extension to open Lemmy links in Thunder
- Added support for displaying comment origin instance - contribution from @ggichure.

## Changed
- Added new items to the Post and Comment actions sheet - contribution from @micahmo
- Added ability to block instance from instance page - contribution from @micahmo

### Fixed

- Fixed issue where custom tabs would not respect default browser when opening links
- Fixed issue where initial app startup takes a long time to load (503 errors)
- Fixed issue where image dimensions were being fetched regardless of post view types (card/compact)

## 0.2.6 - 2023-11-22

### Fixed

- Fixed rendering issues with markdown link parsing
- Fixed issue where TOTP token was not sent properly

## 0.2.5 - 2023-11-15

### Added

- Improved account switching logic - contribution from @micahmo
- Added anonymous browsing mode for any instance - contribution from @micahmo
- Instance autocomplete when logging in - contribution from @micahmo
Expand All @@ -41,20 +48,22 @@
- Added ability to create post from home feed - contribution from @micahmo
- Added option to enter reader mode when tapping on a link in iOS
- Support new scaled and controversial sort types - contribution from @micahmo
- Added support to open Lemmy links in app. Android only. - contribution from @ggichure
- Added support to open Lemmy links in app. Android only. - contribution from @ggichure
- Added support for receiving share intents. Android only. - contribution from @ggichure
- Added ability to block instances from long-press menu and user settings
- Add more search options - contribution from @micahmo
- Added support for display cross-posts - contribution from @micahmo

### Changed

- Collapsed comments are easier to expand - contribution from @micahmo
- Show up to 99 before adding + in the unread count - contribution from @micahmo
- Migrate from old BottomNavigationBar to NavigationBar - contribution from @ggichure
- Adjusted logic to allow for instant switching of sort types, refreshing feed, and switching communities/pages in drawer
- Removed overscroll effect on Android when reduce animation setting is enabled

### Fixed

- Handle issue where failing to retrieve image dimensions blocks post loading - contribution from @Fmstrat
- Show additional posts loading indicator on instances with taglines - contribution from @micahmo
- Fix interactions with saved comments - contribution from @micahmo
Expand All @@ -65,7 +74,9 @@
- Fixed issue where replying from the inbox was not working properly

## 0.2.4 - 2023-09-20

### Added

- Show OP identification first before self/mod/admin - contribution from @micahmo
- Show full text of a URL when activating tooltip on post in feed - contribution from @micahmo
- Redesign UI for creating comments - contribution from @coslu
Expand All @@ -91,6 +102,7 @@
- Added buttons to quickly insert user or community mention in post or comment - contribution from @micahmo

### Changed

- Prioritize and label the default accent color - contribution from @micahmo
- Hide the gesture customize hint when the gestures are disabled - contribution from @micahmo
- Improvements to text post indicator preview - contribution from @micahmo
Expand All @@ -106,6 +118,7 @@
- Hide community name and show usernames when viewing a community - contribution from @micahmo

### Fixed

- Handle issue where some deferred comments won't load - contribution from @micahmo
- Fix issue with taglines reloading too often - contribution from @micahmo
- Fix issue with snackbars not appearing in some cases - contribution from @micahmo
Expand All @@ -120,11 +133,15 @@
- Fix issue where dismiss read FAB action would not work at times

## 0.2.3+16 - 2023-08-15

### Fixed

- Fixed issue with reply FAB action - contribution from @micahmo

## 0.2.2+15 - 2023-08-14

### Added

- Added long press on profile icon to bring up profile modal @zdzoz
- Added spinning circle animation on comment card while waiting for comment to be deleted/restored - contribution from @ajsosa
- Added vote count to comment card in comment list for the user profile - contribution from @ajsosa
Expand Down Expand Up @@ -154,6 +171,7 @@
- Added new option scrape missing external link previews which is off by default. Its purpose is to attempt to find an image when an external link thumbnail is not available - contribution @ajsosa

### Changed

- Removed tap zones for author/community on compact post cards - contribution from @CTalvio
- Creating, deleting, and restoring a comment will update locally without requiring a refetch - contribution from @ajsosa
- Added caching to images to improve overall experience - contribution from @micahmo
Expand All @@ -175,6 +193,7 @@
- Show the currently-selected sort as a subtitle on the post page - contribution from @micahmo

### Fixed

- Fixed issue where the community post feed was missing the last post - contribution from @ajsosa
- Fixed the gesture conflict that can occur between pinch to zoom and tap slide to zoom - contribution from @CTalvio
- Fixed incorrect indentation to load more replies card within comments - contribution from @ajsosa
Expand All @@ -198,7 +217,9 @@
- Fixed double tap zoom sometimes triggering again if attempting to pan immediately after - contribution from @CTalvio

## 0.2.1+13 - 2023-07-25

### Added

- Added swipe gesture to toggle read/unread status on posts - contribution from @micahmo
- Added option to enable/disable text post indicator on compact view - contribution from @micahmo
- Added improvements to link previews to be more stable, and to work more often - contribution from @micahmo
Expand All @@ -225,6 +246,7 @@
- Added subscription icon in post feed when you are subscribed to a given community - contribution from @micahmo

### Changed

- Going back from a selected community in the sidebar will bring you back to the feed view - contribution from @micahmo
- Minor tweaks to toast notification when blocking communities - contribution from @micahmo
- Changed to default feed type to be "All" rather than "Local" - contribution from @micahmo
Expand All @@ -245,6 +267,7 @@
- Adjusted swipe to dismiss on posts to not move divider alongside swipe gesture - contribution from @micahmo

### Fixed

- Fixed issue where comment thread would show spinning indicator even after all comments have been loaded - contribution from @ajsosa
- Fixed minor UI issue where the screen would switch from light-dark-light on app startup - contribution from @micahmo
- Fixed duplicate post regression - contribution from @ajsosa
Expand All @@ -257,7 +280,9 @@
- Fixed issue where the app was preventing you from voting or saving multiple things within a short timeframe

## 0.2.1+12 - 2023-07-18

### Added

- Added community icons to subscription list and search - contribution from @CTalvio
- Added ability to return to homescreen when swiping from post body - contribution from @bactaholic
- Added scroll to top buttons on various pages - contribution from @bactaholic
Expand Down Expand Up @@ -291,12 +316,14 @@
- Added search sort options - contribution from @micahmo

### Changed

- Adjusted subscription styling to be more consistent - contribution from @micahmo
- Removed Sentry error logging
- Tapping outside of the text field when creating a comment/reply will dismiss the keyboard
- Adjusted divider and link preview card colours to have better contrast

### Fixed

- Fixed issue with styling differences in compact and normal view for community/instance - contribution from @machinaeZER0
- Fixed issue with webp previews not showing - contribution from @Fmstrat
- Fixed issue with some links not being parsed properly (GitHub release links)
Expand All @@ -308,7 +335,9 @@
- Potentially fixed issue with profile showing to wrong user

## 0.2.1+11 - 2023-07-09

### Added

- Added colour to username in comments to distinguish your own comments
- Added option to allow text preview on text posts in normal view - contribution from @coslu
- Added option to share media link or external URL links in the dialog popup on post long press
Expand All @@ -327,6 +356,7 @@
- Added minor UI changes to the post view - contribution from @CTalvio

### Changed

- Adjusted visual feedback in comment swipe gestures
- Added option in settings to enable/disable swipe on bottom navigation bar to open sidebar on feed page - contribution from @bactaholic
- Added option in settings to enable/disable double-tap on bottom navigation bar to open sidebar on feed page - contribution from @bactaholic
Expand All @@ -340,6 +370,7 @@
- Community pages now use their display name - contribution from @CTalvio

### Fixed

- Potentially fixed issues with HTTPS certificate errors when running on Android using Adguard with HTTPS filtering enabled
- Improved performance for comment threads with a lot of comments
- Fixed issue where the last comment on a thread could potentially not show up
Expand All @@ -355,7 +386,9 @@
- Fixed issue where not all comments would show up on the profile page - contribution from @ajsosa

## 0.2.1+10 - 2023-07-02

### Added

- Added ability to download images - contribution from @MrAntonS
- Added settings option to collapse parent comment on tap
- Added pull to refresh on posts
Expand All @@ -368,10 +401,12 @@
- Added support for TOTP - contribution from @MrAntonS

### Changed

- Adjusted thickness of divider between posts to help differentiate
- Increased threshold for triggering a upvote/downvote on comments

### Fixed

- Fixed issue where you could not exit app when swiping back or using the back button
- Potentially fixed some issues with performance, yet to be tested widely
- Fixed issue where an error would be thrown if trying to access http pages - contribution from @vbh
Expand All @@ -384,7 +419,9 @@
- Fixing settings not reachable - contribution from @ggichure

## 0.2.1+8 - 2023-06-28

### Added

- Added adaptive icons for Android - contribution from @coslu
- Inbox mentions and replies can now be marked as read
- Added default feed type in settings - contribution from @JulianPaulus
Expand All @@ -400,26 +437,32 @@
- Added settings option to disable swipe gestures on posts

### Changed

- Moved theming options into a separate section in settings
- Adjusted inbox show all toggle to be a button to be more descriptive
- Adjusted logic for fetching and caching images to bring better performance
- Changed slide to dismiss images to use a new library
- Tapping on a comment will only collapse the replies to that comment - contribution from @vbh

### Fixed

- Fixed issue with sort type not being respected on refresh - contribution from @JulianPaulus
- Fixed issue where comment upvote/downvote did not display properly
- Fixed issue where navigation bar was black on Android devices
- Fixed issue where Thunder would redirect you to the feed page after changing settings

## 0.2.1+7 - 2023-06-25

### Fixed

- Fixed issue where creating a comment on a post would not work
- Added back icon to image preview for edge cases where the swipe down gesture does not work
- Fixed issue where inbox shows all replies and comments first, rather than just unread messages

## 0.2.1+6 - 2023-06-25

### Added

- External links can now be opened in an external browser, and also shared using the system's sharing options
- Improved GIF support - contribution from @MrAntonS
- Improved accessibility labels for icons and actions
Expand All @@ -433,19 +476,23 @@
- Swiping down or up on a full screen photo will now dismiss it

### Changed

- Adjusted size of create comment bottom modal, and enabled text selection within the modal for the parent's comment
- Slight improvements to account/profile selection to show which profile is currently active
- When scrolling to the bottom of comments, the FAB for replying will automatically disappear so that the comment is not obstructed
- Search now sorts by Active rather than the default provided by lemmy - contribution from @Benjamint22
- Subscriptions list on the sidebar will now load up to 50 rather than 10

### Fixed

- Potentially fixed issue where scrolling behaviour is weird when creating a new post or comment
- Fixed issue where usernames/passwords containing leading or trailing spaces may fail to login - contribution from @MrAntonS
- Fixed issue where passwords with a length > 60 would throw an error "incorrect password"

## 0.2.1+5 - 2023-06-22

### Added

- Added basic ability to post to a community with Markdown
- Added basic ability to create a comment in a post and to reply to other comments
- Added settings option to enable or disable the in-app update notifications
Expand All @@ -457,14 +504,18 @@
- Added ability to opt-in/opt-out of Sentry error reporting

### Changed

- Searching now fetches more results as you scroll down

### Fixed

- Fixed issue where selecting the light theme would revert back to dark theme on app relaunch
- Fixed issue where link previews were not being shown properly

## 0.2.0-alpha - 2023-06-20

### Added

- New update in-app notification to notify you of new GitHub releases
- Autofill options for logging into your account (tested on iOS, untested on Android physical device)
- Added an option to switch to a light theme
Expand All @@ -477,22 +528,29 @@
- Vote and comment actions are hidden/disabled when not logged in

### Fixed

- Fixed issue where refreshing or selecting a sort option would cause the feed to show the Local feed

## 0.1.1-alpha - 2023-06-16

### Added

- Switching between tabs keeps the state of the tab
- Added Sentry to allow for debugging and logging

### Changed

- Initial feed now shows a compact version of an image, rather than the full height image

### Fixed

- Fixed issue where if you log in with an instance that does not exist, the community page will indefinitely load
- Fixed issue where a community would show a loading indicator if there were too little posts within that community

## 0.1.0-alpha - 2023-06-15

### Added

- Sorting post feed by hot, active, etc.
- Tap on community name in post to view community
- Upvote, downvote, and save posts
Expand All @@ -501,6 +559,7 @@
- Sign in to single account

### Missing Core Features

- No ability to create a post or comment
- No user notifications
- No ability to browse saved comments and posts
Expand Down
1 change: 1 addition & 0 deletions lib/core/enums/local_settings.dart
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ enum LocalSettings {
defaultCommentSortType(name: 'setting_post_default_comment_sort_type', label: 'Default Comment Sort Type'),
collapseParentCommentBodyOnGesture(name: 'setting_comments_collapse_parent_comment_on_gesture', label: 'Hide Parent Comment on Collapse'),
showCommentActionButtons(name: 'setting_general_show_comment_button_actions', label: 'Show Comment Button Actions'),
commentShowUserInstance(name: 'settings_comment_show_user_instance', label: 'Show User Instance'),
combineCommentScores(name: 'setting_general_combine_comment_scores', label: ''),
nestedCommentIndicatorStyle(name: 'setting_general_nested_comment_indicator_style', label: 'Nested Comment Indicator Style'),
nestedCommentIndicatorColor(name: 'setting_general_nested_comment_indicator_color', label: 'Nested Comment Indicator Color'),
Expand Down
6 changes: 5 additions & 1 deletion lib/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -863,5 +863,9 @@
"description": "The total score of post or comment"
},
"xUpvotes": "{x} upvotes",
"@xUpvotes": {}
"@xUpvotes": {},
"commentShowUserInstance":"Show User Instance",
"@commentShowUserInstance":{
"description":"Settings toggle to display user instance alongside their display name in comments"
}
}
Loading

0 comments on commit fe2a91c

Please sign in to comment.