add support for displaying comment origin instance #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahmo
reviewed
Dec 3, 2023
There was a problem hiding this comment.
Hey thanks so much for taking this on! I love the approach you've taken to display the instance name in a slightly different styling than the username. This is something I've liked from Boost/Sync and thought about bringing over here. I wonder if (in the future) we should consider styling community names the same way (instead of with the dot) for consistency. Just a thought!
hjiangsu
reviewed
Dec 5, 2023
|
This looks great! I like the formatting you used, and (of course) appreciate a good toggle :) |
renamed showOriginIntance to commentShowUserInstance,fix typos,fix Richtext text scaling
hjiangsu
reviewed
Dec 8, 2023
hjiangsu
approved these changes
Dec 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add support for displaying comment origin instance. Toggle on and off via settings.
Issue Being Fixed
Add support for displaying comment origin instance
Issue Number: #200
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?