Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user about the consequences of disconnecting a calendar. #160

Merged

Conversation

MelissaAutumn
Copy link
Member

This doesn't fix #142 but it does warn the user about it. We might want to give this user flow a bit of a think, as it can lead to big breakages as we've seen with this issue ticket 😄

image

@MelissaAutumn MelissaAutumn self-assigned this Oct 20, 2023
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mel! This looks good. We can extend that if needed in the future. I also added German translations for your changes.

@MelissaAutumn MelissaAutumn merged commit 1675208 into main Oct 25, 2023
devmount added a commit that referenced this pull request Nov 6, 2023
* Swap siteNotification to use a pinia store, and make the z-index bigger. (Fixes #151) (#152)

* Bugs/145 ga disclaimer and visual improvements (#153)

* 📜 improving copy

* 💚 improve spacing in home view

* 💚 improve footer bottom position without scroll bars

* 🔨 handle empty schedules list

* Bugs/154 calendar sync (#155)

* 🔨 only json load google token if it exists

* 🔨 fix sync button styles

* Improving copy (#156)

* Rename instances of thundernest to thunderbird. (#163)

* Warn the user about the consequences of disconnecting a calendar. (#160)

* Warn the user about the consequences of disconnecting a calendar.

* ➕ update locales

---------

Co-authored-by: Andreas Müller <mail@devmount.de>

* Features/105 GA booking request flow (#159)

* ➕ use slots for availability attendees

* ➕ extend booking flow for availabilities (wip)

* 📜 update er documentation

* ➕ implement request confirmation mail

* ➕ add booking confirmation view

* ➕ create loading spinner component

* ➕ availability request handling

* ➕ add external link to my link settings

* ➕ add booking status

* ❌ remove console statement

* 📜 update documentation

* 🔨 make date format constant

* ❌ remove unused code

* ➕ add check for previously booked slot

* Remove carriage return (#167)

* ❌ rmove cr, keep lf

* ❌ remove cr, keep lf

* Add booking request denial information (#168)

---------

Co-authored-by: Mel <97147377+MelissaAutumn@users.noreply.github.com>
@devmount devmount deleted the features/142-warn-user-about-calendar-disconnecting branch February 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My link (aka short link) for user's GA takes you to error page
2 participants