Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/105 GA booking request flow #159

Merged
merged 14 commits into from
Nov 3, 2023
Merged

Conversation

devmount
Copy link
Collaborator

@devmount devmount commented Oct 20, 2023

Description of the Change

This change implements a confirmation step into the existing booking flow for availability bookings from schedules.

Availability time slots are generated on the fly from the schedule configuration. As soon as somebody request one of the time slots, an actual database record is created for this slot to handle confirmation with unique token, expiration date and booking status.

Example of a booking request confirmation mail to the calendar owner:

image

Clicking the confirm button would update the slot status to booked, send the invitation to the attendee and show this view:

image

Clicking the deny button would result in deleting the actual time slot and showing this view:

image

Accessing an already processed url again or messing around with the url would result in showing this view:

image

🛢 This PR requires a database migration!

Applicable Issues

Implements #105

@devmount devmount linked an issue Oct 20, 2023 that may be closed by this pull request
@devmount devmount self-assigned this Oct 21, 2023
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, will give thid a comprehensive review once its finished 😀

backend/src/appointment/controller/calendar.py Outdated Show resolved Hide resolved
backend/src/appointment/database/models.py Show resolved Hide resolved
@devmount devmount changed the title DRAFT: Features/105 GA booking request flow Features/105 GA booking request flow Oct 24, 2023
@devmount devmount mentioned this pull request Nov 2, 2023
@devmount devmount merged commit 714ca70 into main Nov 3, 2023
@devmount devmount deleted the features/105-ga-booking-request branch November 3, 2023 21:47
devmount added a commit that referenced this pull request Nov 6, 2023
* Swap siteNotification to use a pinia store, and make the z-index bigger. (Fixes #151) (#152)

* Bugs/145 ga disclaimer and visual improvements (#153)

* 📜 improving copy

* 💚 improve spacing in home view

* 💚 improve footer bottom position without scroll bars

* 🔨 handle empty schedules list

* Bugs/154 calendar sync (#155)

* 🔨 only json load google token if it exists

* 🔨 fix sync button styles

* Improving copy (#156)

* Rename instances of thundernest to thunderbird. (#163)

* Warn the user about the consequences of disconnecting a calendar. (#160)

* Warn the user about the consequences of disconnecting a calendar.

* ➕ update locales

---------

Co-authored-by: Andreas Müller <mail@devmount.de>

* Features/105 GA booking request flow (#159)

* ➕ use slots for availability attendees

* ➕ extend booking flow for availabilities (wip)

* 📜 update er documentation

* ➕ implement request confirmation mail

* ➕ add booking confirmation view

* ➕ create loading spinner component

* ➕ availability request handling

* ➕ add external link to my link settings

* ➕ add booking status

* ❌ remove console statement

* 📜 update documentation

* 🔨 make date format constant

* ❌ remove unused code

* ➕ add check for previously booked slot

* Remove carriage return (#167)

* ❌ rmove cr, keep lf

* ❌ remove cr, keep lf

* Add booking request denial information (#168)

---------

Co-authored-by: Mel <97147377+MelissaAutumn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Availability - Request to book email
2 participants