feat: interactive calibrator - new api #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vividf
approved these changes
Aug 20, 2024
|
*Tested |
|
@knzo25 got it! |
|
@vividf ? |
Base automatically changed from
feature/new_api_documentation
to
tier4/universe
September 24, 2024 12:33
…d fixed some bugs Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
knzo25
force-pushed
the
feat/interactive_calibrator_new_api
branch
from
1cf3e2b
to
357dced
Compare
vividf
requested changes
Nov 11, 2024
There was a problem hiding this comment.
I run the interactive calibrator in the default project with the camera_lidar.db3 rosbag provided in the pnp tutorial.
However, camera image didn't show up in the UI and the pointcloud didn't show up in the rviz2.
Could you provide more detail information how you test this PR?
| Filter size: 10 | ||
| History Policy: Keep Last | ||
| Reliability Policy: Best Effort | ||
| Value: /sensing/lidar/concatenated/pointcloud |
There was a problem hiding this comment.
Please change the default value to the input pointcloud instead of the concatenated pointcloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should be reviewed after the documentation gets merged (and rebased before merged)
It is has little to no priority compared with other calibration tools tasks
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.