Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edge_auto): added initial support for edge auto calibration #193

Open
wants to merge 3 commits into
base: tier4/universe
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Sep 24, 2024

Description

Implemented initial support for edge auto

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 and others added 3 commits September 25, 2024 08:26
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
* chore: adapted to the new way of using lidartag

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* chore: rename decompressed_topic name to avoid name conflict on live

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* feat: introduce `choice` for bool options

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* fix: init tf tree visualization (#188)

* fix: init tf tree visualization

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix error

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

---------

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* fix(intrinsic_camera_calibrator): fixed dot board detector (#189)

fix: forgot to add a fix to the dot board detector

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Co-authored-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yi-Hsiang Fang (Vivid) <146902905+vividf@users.noreply.github.com>
@knzo25 knzo25 requested a review from manato September 24, 2024 23:28
@knzo25 knzo25 self-assigned this Sep 24, 2024
@knzo25
Copy link
Collaborator Author

knzo25 commented Sep 24, 2024

@manato
I rebased the branch so that it can be merged into our main branch. If you can take a look is would be highly appreciated

@knzo25
Copy link
Collaborator Author

knzo25 commented Sep 24, 2024

@vividf
I was checking the commits while rebasing and yours 159d923
was introducing a bug in which the raw image was being send through the network (potentially) which is known to cause instabilities. Hirabayashi-san seems to have caught on it later, but be careful

@vividf
Copy link
Contributor

vividf commented Sep 25, 2024

@knzo25 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants