Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(system_monitor): disable traffic monitor #685

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

iwatake2222
Copy link

@iwatake2222 iwatake2222 commented Nov 25, 2024

Description

launcher change for autowarefoundation/autoware.universe#9069

This PR disables traffic monitor. Traffic monitor is one of modules in system monitor, which measures network traffic by specified programs ( the default target program is greengrass ).

The traffic monitor uses nethogs to monitor network, but the CPU usage of nethogs is high in some systems. This PR adds a new config to enable/disable traffic monitor, but the default setting is enabled for OSS Autoware.Universe

For our usage, network traffic by program is not necessarily collected by default, while network bandwidth and errors are useful. This PR disables traffic monitor only.

Tests performed

nethogs command doesn't run when enable_traffic_monitor is false

image

Effects on system behavior

Not applicable.

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
@iwatake2222 iwatake2222 changed the base branch from main to tier4/main November 25, 2024 06:08
@iwatake2222 iwatake2222 changed the title System monitor disable traffic monitor chore(system_monitor): disable traffic monitor Nov 25, 2024
@iwatake2222 iwatake2222 marked this pull request as ready for review November 25, 2024 06:15
@iwatake2222 iwatake2222 marked this pull request as draft November 25, 2024 06:19
@iwatake2222 iwatake2222 marked this pull request as ready for review November 27, 2024 02:27
@iwatake2222
Copy link
Author

@ito-san
Could you review this PR?
Also, please add label to run build-and-test-differential check.

@iwatake2222
Copy link
Author

@ito-san
It's just a friendly reminder 🥹 🥹 🥹

@ito-san ito-san enabled auto-merge December 4, 2024 09:58
@ito-san ito-san merged commit 7d9aeae into tier4/main Dec 4, 2024
39 of 43 checks passed
@ito-san ito-san deleted the system_monitor_disable_traffic_monitor branch December 4, 2024 09:59
Copy link

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to stop monitoring with nethogs by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants