feat: add yabloc scenario #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
7 tasks
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
hayato-m126
requested changes
Aug 1, 2023
There was a problem hiding this comment.
It's a minor detail, but please fix UseCaseFormatVersion.
https://tier4.github.io/driving_log_replayer/scenario_format/#usecaseformatversion
sample/yabloc/scenario.yaml
Outdated
| LocalMapPath: $HOME/autoware_map/sample-map-planning | ||
| Evaluation: | ||
| UseCaseName: yabloc | ||
| UseCaseFormatVersion: 1.2.0 |
There was a problem hiding this comment.
UseCaseFormatVersion should be started at 0.1.0 and raised to 1.0.0 when the evaluation method is finalized.
Suggested change
| UseCaseFormatVersion: 1.2.0 | |
| UseCaseFormatVersion: 0.1.0 |
There was a problem hiding this comment.
Fixed: b3fb51d
Thank you!
Co-authored-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Types of PR
Description
I'd like to add YabLoc evaluator scenario.
INTERNAL LINKS:
How to review this PR
Please follow the documentation for yabloc scenario and confirm that it actually runs with a sample rosbag
Others