This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
feat: add ground_segmentation evaluator #479
Closed
nanoshimarobot
wants to merge
56
commits into
tier4:develop
from
nanoshimarobot:feat/ground_segmentation_pcd_eval
Closed
feat: add ground_segmentation evaluator #479
nanoshimarobot
wants to merge
56
commits into
tier4:develop
from
nanoshimarobot:feat/ground_segmentation_pcd_eval
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- judge if the cloud has entity_id field
nanoshimarobot
changed the title
feat: add ground_segmentation evaluation
feat: add ground_segmentation evaluator
Jun 11, 2024
@nanoshimarobot Thanks for PR. Could you grant me access to the test data? |
I apologize for the late reply. Access rights have been granted, so please check. |
Comment on lines
28
to
33
autoware_launch = cmn.get_autoware_launch( | ||
planning="false", | ||
localization="false", | ||
control="false", | ||
scenario_simulation="true", | ||
perception_mode="lidar", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanoshimarobot Thank you for your PR.
Since concatenated/pointcloud is already included in T4_dataset, could you add the option to disable "sensing" when running autoware?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review.
I have modified ground_segmentation.launch.py @cc2e297
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of PR
Description
Add ground segmentation evaluator scenario.
Point cloud data in the t4_dataset needs to have semantic label(ground truth), provided #107, etc.
How to review this PR
Please download test data : TIERIV INTERNAL LINK
The output should look like this:
Others