Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai_hw_interface): fix spelling errors #43

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Jul 30, 2023

PR Type

  • Bug Fix

Related Links

Description

Minor spellcheck fix.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: David Wong <david.wong@tier4.jp>
@drwnz drwnz requested a review from amc-nu July 30, 2023 09:17
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -5.78% ⚠️

Comparison is base (2249891) 13.38% compared to head (59d0e40) 7.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             main     #43      +/-   ##
=========================================
- Coverage   13.38%   7.61%   -5.78%     
=========================================
  Files         111      36      -75     
  Lines       10990    6831    -4159     
  Branches     1727    1145     -582     
=========================================
- Hits         1471     520     -951     
+ Misses       8338    5368    -2970     
+ Partials     1181     943     -238     
Flag Coverage Δ
differential 7.61% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% <0.00%> (ø)

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drwnz drwnz merged commit 189d7e2 into main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants