Skip to content
This repository has been archived by the owner on Aug 27, 2021. It is now read-only.

Fix CI settings #23

Merged
merged 19 commits into from
Mar 30, 2021
Merged

Fix CI settings #23

merged 19 commits into from
Mar 30, 2021

Conversation

kenji-miyake
Copy link
Contributor

What kinds of PR

  • New feature
  • Improve feature
  • Bug fix

What is this PR

Fix CI settings.

How to check this PR

Check CI result.

Kenji Miyake added 13 commits March 29, 2021 01:01
Fix long name
26b160a 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Remvoe probably unnecessary comments
3ae37a8 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Revive fail_ci_if_error of Codecov
7b78af9 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Add workflow_dispatch to all workflows
623bee7 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Use ubuntu-latest
4129d00 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Add container
fc3c62e 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Replace unnecessary id plum to set_env
7f921a7 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Unify github action's version
d3b521f 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Define GITHUB_PAGES_URL
6935ce5 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Fix name
c1ee301 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Delete unnecessary workflow_dispatch
0c0f938 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Fix lizard command
29a6876 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Change file name
cee951b 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@github-actions
Copy link

📊 Code Metrics Report

Branch Metrics
This PR code-metrics.html
main code-metrics.html

@KeisukeShima
Copy link
Collaborator

KeisukeShima commented Mar 29, 2021 •
edited
Loading

@kenji-miyake I found that $GITHUB_PAGES_URL generates wrong URL. Please check https://tier4.github.io/obstacle_stop_planner_refine/pr-check/index.html.

Generaeted URL:
https://tier4.github.io/obstacle_stop_planner_refine/pr-check/$GITHUB_PAGES_URL/pr-check/index.html

Desired URL:
https://tier4.github.io/obstacle_stop_planner_refine/pr-check/pr23/code-metrics.html

I'm looking for the cause of the CI breaking.

KeisukeShima
KeisukeShima reviewed Mar 29, 2021
View reviewed changes
.github/workflows/code_metrics_pr.yml Outdated Show resolved Hide resolved
.github/workflows/code_metrics_main.yml Outdated Show resolved Hide resolved
kenji-miyake and others added 5 commits March 29, 2021 17:32
@kenji-miyake @KeisukeShima
Update .github/workflows/code_metrics_pr.yml
fb2b2af 
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
@kenji-miyake @KeisukeShima
Update .github/workflows/code_metrics_main.yml
97480d2 
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
@kenji-miyake @kmiya
Update .github/workflows/build_and_test.yml
b1bc7cb 
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
@kenji-miyake @kmiya
Update .github/workflows/nightly_clang_build.yml
8679951 
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
@kenji-miyake @kmiya
Update .github/workflows/nightly_clang_build.yml
7b91f24 
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Fixup
875dc4d 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@codecov-io
Copy link

codecov-io commented Mar 29, 2021 •
edited
Loading

Codecov Report

Merging #23 (875dc4d) into main (aaa2a32) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            main     #23    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          5       4     -1     
  Lines       1141     926   -215     
======================================
+ Misses      1141     926   -215
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
obstacle_stop_planner_refine/src/node.cpp 0.00% <0.00%> (ø)
obstacle_stop_planner_refine/src/debug_marker.cpp 0.00% <0.00%> (ø)
obstacle_stop_planner_refine/src/main.cpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa2a32...875dc4d. Read the comment docs.

@KeisukeShima KeisukeShima merged commit 8e09f12 into main Mar 30, 2021
@KeisukeShima KeisukeShima deleted the fix-ci-settings branch March 30, 2021 00:39
kmiya
kmiya reviewed Mar 30, 2021
View reviewed changes
.github/workflows/nightly_clang_build.yml
@@ -8,7 +8,6 @@ on:
jobs:
build-using-clang:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenji-miyake Thank you for the fixes.
I wanted to use ubuntu:focal because our development environment is Ubuntu 20.04 focal.
As described in the official document, ubuntu:latest tag points to the latest LTS version, that is, it will be changed to another version a few years later. It might be no problem, but I would like to mention that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmiya Thank you, I understand.
Though I wanted to use ubuntu:focal, but temporarily disabled it for consistency because some workflows didn't work with containers...
I'll try to solve the problem and revert container tag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmiya kmiya kmiya left review comments

@KeisukeShima KeisukeShima KeisukeShima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenji-miyake @KeisukeShima @codecov-io @kmiya