Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RJD-1200] to Investigate why an Autoware with scenario_simulator_v2 does not work with cpp scenarios #1330

Closed
wants to merge 77 commits into from

Conversation

SzymonParapura
Copy link
Contributor

@SzymonParapura SzymonParapura commented Jul 29, 2024

Description

Abstract

This pull request addresses and fixes issues in the random001 scenario. Additionally, it ensures support and compatibility with the autoware_msgs header files.

Details

The first issue encountered when running the random001 scenario was related to incompatible header files ("autoware_auto_msgs" instead of "autoware_msgs"). SS2 on the master branch uses an older version of the header files that are not compatible with Autoware. Therefore, this PR includes changes from the RJD-736/autoware_msgs_support branch to ensure support and compatibility with autoware_msgs header files.

Additionally, several bugs were found:

  • Added condition to check if ego reaches the goal position and to end the scenario with success.
  • Removed if condition causing redundant failure when spawn_nearby_ego is already spawned.
  • Adjusted despawn logic for spawn_nearby_ego.
  • Fixed an issue with invalid RViz plugin names.

References

Jira ticket: link

Destructive Changes

There are no destructive changes

Known Limitations

N/A

kielczykowski-rai and others added 30 commits February 29, 2024 13:04
HansRobo and others added 21 commits June 21, 2024 15:00
…nto feature/manual_on_follow_trajectory_not_auto

# Conflicts:
#	simulation/traffic_simulator/include/traffic_simulator/entity/entity_manager.hpp
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
feat: add `autoware_` prefix to `lanelet2_extension`
- Added condition to check if ego reaches the goal position and to end scenario with success.
- Removed if condition causing redundant failure when spawn_nearby_ego is already spawned.
- Adjusted despawn logic for spawn_nearby_ego.
- Fixed an issue with invalid rviz plugin names.
@SzymonParapura SzymonParapura added the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Jul 29, 2024
Copy link

github-actions bot commented Jul 29, 2024

This PR edits vehicle model that is copied from simple_planning_simulator. Please consider making changes to the original code to avoid confusion or consult developers (@hakuturu583, @yamacir-kit and @HansRobo ).

@SzymonParapura SzymonParapura marked this pull request as draft July 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants