Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ros2 parameter forwarding #1362

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Sep 3, 2024

Description

Abstract

Added forwarding of scenario_test_runner launch arguments prefixed with autoware. to Autoware.

Background

Previously, scenario_test_runner had no mechanism to pass arbitrary launch arguments to Autoware that were not directly supported by scenario_test_runner. This was not due to scenario_test_runner design or technical reasons, but simply because such functionality was not implemented. Therefore, a mechanism was implemented to forward arbitrary launch arguments from scenario_test_runner to Autoware.

Details

All launch arguments given to scenario_test_runner with names starting with autoware. are collected together as a list of strings consisting of the prefix-stripped argument names and their values.
The collected arguments are passed to openscenario_interpreter and simple_sensor_simulator as a new ROS 2 parameter named autoware.. Finally, openscenario_interpreter passes the elements of the ROS 2 parameter autoware. together with other existing parameters to the launch argument of Autoware.

References

Destructive Changes

None.
Some existing launch arguments should be able to be replaced with those of the autoware. prefix, but for backward compatibility, we will not modify the existing arguments.

Known Limitations

None.

Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
@yamacir-kit yamacir-kit added the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Sep 3, 2024
@yamacir-kit yamacir-kit self-assigned this Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
@HansRobo HansRobo merged commit 0b7c0ed into master Sep 9, 2024
15 checks passed
@HansRobo HansRobo deleted the feature/ros2-parameter-forwarding branch September 9, 2024 04:43
@github-actions github-actions bot restored the feature/ros2-parameter-forwarding branch September 9, 2024 04:44
@github-actions github-actions bot deleted the feature/ros2-parameter-forwarding branch September 9, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants