Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support march 2024 RX2 conversion #120

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Conversation

miursh
Copy link
Collaborator

@miursh miursh commented Jun 30, 2024

Description

  • Added CAM_FRONT_NARROW, CAM_FRONT_WIDE, and LIDAR_FRONT to SENSOR_ENUM.
  • Fixed a bug related to the dummy image timestamp.
  • Raised a KeyError to notify when a topic is not found in the input bag file, improving error handling and helping users quickly identify missing topics during bag file processing.

This pull request includes several updates to the perception_dataset module, focusing on expanding sensor enumerations and improving error handling and synchronization logic.

Sensor Enumeration Updates:

Error Handling Improvements:

Synchronization Logic Enhancement:

  • perception_dataset/utils/misc.py: Updated get_lidar_camera_synced_frame_info to handle cases where the current_image_index exceeds the length of image_timestamp_list by setting a dummy timestamp.

miursh and others added 7 commits June 16, 2024 10:05
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
- Modify _generate_image_data to accept both np.ndarray and CompressedImage types
- Add image_shape parameter to properly set image dimensions
- Ensure correct saving of CompressedImage data

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
# Conflicts:
#	perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py
@miursh miursh marked this pull request as ready for review September 19, 2024 16:57
@miursh miursh changed the title feat: fs rx2 conversion feat: support march 2024 RX2 conversion Sep 23, 2024
@miursh miursh merged commit dd858df into main Oct 14, 2024
5 checks passed
@miursh miursh deleted the feat/fs_rx2_conversion branch October 14, 2024 14:59
nanoshimarobot pushed a commit to nanoshimarobot/tier4_perception_dataset that referenced this pull request Nov 24, 2024
* Output topic drop error during initialization

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Avoid out-of-bounds access in get_lidar_camera_synced_frame_info

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Enhance image data handling to support CompressedImage format

- Modify _generate_image_data to accept both np.ndarray and CompressedImage types
- Add image_shape parameter to properly set image dimensions
- Ensure correct saving of CompressedImage data

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* add RX2 constants

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant