Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rosbag2_to_non_annotated_t4): decoding pointcloud2 msg #137

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix(rosbag2_to_non_annotated_t4): decoding pointcloud2 msg #137

merged 2 commits into from
Aug 1, 2024

Conversation

miursh
Copy link
Collaborator

@miursh miursh commented Aug 1, 2024 •
edited
Loading

Description

Fix intensity decoding during the conversion of rosbag2 to the non-annotated T4 format.

How to review

How to test

Use any rosbag file.
Check the intensity of pointcloud in the non-annotated t4 format dataset.

Before:
CAM_FRONT_WIDE_000019

After:
CAM_FRONT_WIDE_000019

python -m perception_dataset.convert --config config/convert_rosbag2_to_non_annotated.yaml --overwrite --without_compress

Reference

Notes for reviewer

@miursh
fix decoding pointcloud2 msg
fda5af7 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh requested review from Guolong-Zhang and kminoda August 1, 2024 02:19
@miursh miursh changed the title fix decoding pointcloud2 msg fix(rosbag2_to_non_annotated_t4): decoding pointcloud2 msg Aug 1, 2024
@miursh
fix comments
5e1ed80 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
kminoda
kminoda approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@kminoda kminoda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Confirmed that the intensity field was within an appropriate range

@miursh miursh merged commit f81e94d into main Aug 1, 2024
5 checks passed
@miursh miursh deleted the fix/decode_intensity branch August 1, 2024 09:18
@kminoda kminoda mentioned this pull request Aug 13, 2024
Merged
nanoshimarobot pushed a commit to nanoshimarobot/tier4_perception_dataset that referenced this pull request Nov 24, 2024
@miursh @nanoshimarobot
fix(rosbag2_to_non_annotated_t4): decoding pointcloud2 msg (tier4#137)
5822641 
* fix decoding pointcloud2 msg

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix comments

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminoda kminoda kminoda approved these changes

@Guolong-Zhang Guolong-Zhang Awaiting requested review from Guolong-Zhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miursh @kminoda