feat(rosbag2_to_non_annotated_t4): support uint8 intensity #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Shin-kyoto
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
LGTM
- I confirmed that this PR's content is consistent with the autoware documentation.
- I confirmed that
ros2_numpypackage is not used now and we can remove it. - I DID NOT check this PR with running tier4_perception_dataset.
nanoshimarobot
pushed a commit
to nanoshimarobot/tier4_perception_dataset
that referenced
this pull request
Nov 24, 2024
* fix decoding pointcloud2 msg Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix comments Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * support uint8 Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove ros2-numpy from poetry Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> --------- Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to review
How to test
test data
test command
Reference
Notes for reviewer