fix(non_annotated_t4_to_deepen): fix frame skipping logic #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
kminoda
reviewed
Sep 11, 2024
perception_dataset/deepen/non_annotated_t4_to_deepen_converter.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
|
@kminoda |
kminoda
approved these changes
Sep 18, 2024
nanoshimarobot
pushed a commit
to nanoshimarobot/tier4_perception_dataset
that referenced
this pull request
Nov 24, 2024
* fix skip frame logic Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * increment the version number Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * refactor: extract get_camera_token into a separate function Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> --------- Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the frame skipping logic that was introduced in #114, where frames were being skipped incorrectly under certain conditions.
This fix ensures that frame skipping now functions as intended
How to review
How to test
test data