Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error log of TSO doesn't print the cause #7496

Closed
CabinfeverB opened this issue Dec 6, 2023 · 0 comments · Fixed by #7497
Closed

The error log of TSO doesn't print the cause #7496

CabinfeverB opened this issue Dec 6, 2023 · 0 comments · Fixed by #7497
Assignees
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

CabinfeverB commented Dec 6, 2023

Bug Report

[2023/12/06 10:46:41.796 +08:00] [ERROR] [tso_dispatcher.go:498] ["[tso] getTS error"] [dc-location=global] [stream-addr=http://127.0.0.1:49408] [error="[PD:client:ErrClientGetTSO]get TSO failed, after processing requests"]

but

pd/client/tso_dispatcher.go

Lines 493 to 496 in ef6ba85

log.Error("[tso] getTS error",
zap.String("dc-location", dc),
zap.String("stream-addr", streamAddr),
errs.ZapError(errs.ErrClientGetTSO.FastGenByArgs("after processing requests"), err))

And more, I do a test for ZapError

err1 := errors.New("test")
	log.Error("[pd] failed to close grpc clientConn", errs.ZapError(errs.ErrCloseGRPCConn, err1))

It prints

[2023/12/06 10:53:11.164 +08:00] [ERROR] [client_test.go:505] ["[pd] failed to close grpc clientConn"] [error="[PD:grpc:ErrCloseGRPCConn]test: test"] [stack="github.com/tikv/pd/tests/integrations/client_test.TestCustomTimeout\n\t/Users/jiangyongbo/github/pd/tests/integrations/client/client_test.go:505\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1595"]

"close gRPC connection failed" is overwritten by "test"

What did you do?

What did you expect to see?

What did you see instead?

What version of PD are you using (pd-server -V)?

@CabinfeverB CabinfeverB added type/bug The issue is confirmed as a bug. severity/minor affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 6, 2023
@CabinfeverB CabinfeverB self-assigned this Dec 6, 2023
ti-chi-bot bot added a commit that referenced this issue Dec 13, 2023
close #7496

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Dec 13, 2023
close tikv#7496

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this issue Dec 22, 2023
close #7496

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
ti-chi-bot bot added a commit that referenced this issue Dec 22, 2023
close #7496

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Mar 1, 2024
ref #7496

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant