Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Start switching to the zap logger #1422

Merged
merged 11 commits into from
Feb 14, 2019
Merged

*: Start switching to the zap logger #1422

merged 11 commits into from
Feb 14, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jan 30, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

In order to smoothly switch to the new logger

What is changed and how it works?

  • Replace logger with pingcap/log global logger
  • Use customer zap logger in etcd

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
cmd/pd-server/main.go Outdated Show resolved Hide resolved
server/config.go Show resolved Hide resolved
server/config.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1422 into master will decrease coverage by 0.17%.
The diff coverage is 68.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1422      +/-   ##
=========================================
- Coverage   67.77%   67.6%   -0.18%     
=========================================
  Files         158     158              
  Lines       15006   15038      +32     
=========================================
- Hits        10171   10167       -4     
- Misses       3912    3942      +30     
- Partials      923     929       +6
Impacted Files Coverage Δ
pkg/logutil/log.go 83.62% <100%> (ø) ⬆️
server/testutil.go 91.66% <100%> (+0.96%) ⬆️
server/util.go 70.27% <30.76%> (-3.68%) ⬇️
tests/cluster.go 83.33% <62.5%> (-0.46%) ⬇️
server/server.go 77.61% <75%> (-0.28%) ⬇️
server/config.go 81.26% <81.81%> (-0.92%) ⬇️
server/etcd_kv.go 63.63% <0%> (-7.28%) ⬇️
server/coordinator.go 79.26% <0%> (-5.29%) ⬇️
server/api/redirector.go 78.94% <0%> (-5.27%) ⬇️
server/leader.go 78.11% <0%> (-5.16%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93cac8...0cd705d. Read the comment docs.

@nolouch
Copy link
Contributor Author

nolouch commented Feb 13, 2019

/rebuild

server/testutil.go Outdated Show resolved Hide resolved
server/util.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch merged commit 225948c into tikv:master Feb 14, 2019
@nolouch nolouch deleted the log-update branch February 14, 2019 06:09
@nolouch nolouch added the component/log Log. label Feb 18, 2019
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <rleungx@gmail.com>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <rleungx@gmail.com>=

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants