Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: improve some logs #1516

Merged
merged 4 commits into from
Apr 24, 2019
Merged

*: improve some logs #1516

merged 4 commits into from
Apr 24, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 23, 2019

What problem does this PR solve?

Do the same thing with #1511, but #1511 was closed by accident.

What is changed and how it works?

See #1511

Check List

Tests

  • Unit test

rleungx added 2 commits April 23, 2019 20:55
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/log Log. label Apr 23, 2019
@rleungx rleungx requested review from nolouch and disksing April 23, 2019 13:10
@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #1516 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage    67.6%   67.64%   +0.04%     
==========================================
  Files         158      158              
  Lines       15624    15632       +8     
==========================================
+ Hits        10563    10575      +12     
+ Misses       4099     4092       -7     
- Partials      962      965       +3
Impacted Files Coverage Δ
server/region_syncer/server.go 81.89% <100%> (ø) ⬆️
server/cluster.go 75.33% <100%> (-0.28%) ⬇️
server/leader.go 78.83% <100%> (+0.26%) ⬆️
server/coordinator.go 84.64% <100%> (+0.06%) ⬆️
server/api/redirector.go 78.94% <0%> (-5.27%) ⬇️
server/region_syncer/client.go 77.21% <0%> (-2.54%) ⬇️
server/schedule/region_scatterer.go 86.02% <0%> (-2.21%) ⬇️
server/handler.go 54.96% <0%> (-0.51%) ⬇️
client/client.go 68.46% <0%> (-0.44%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6720d35...d69a7cd. Read the comment docs.

@nolouch nolouch merged commit bd1e249 into tikv:master Apr 24, 2019
@rleungx rleungx mentioned this pull request May 5, 2019
nolouch pushed a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <rleungx@gmail.com>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <rleungx@gmail.com>=

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants