Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We recently encountered a problem, which PD cannot delete the leader key due to somewhere hanging. So the new leader cannot be elected. Such problems are not easy to trace once the scene didn't be saved. We can't check the goroutine status. Under this circumstance, it's hard for us to know if this hanging is caused by our code or
etcd
. For now, we need to wait for some goroutines to exit before deleting the key. And we don't know if these goroutines exit accurately.What is changed and how it works?
This PR improves some logs to help us trace the problem better.
Check List
Tests