*: add GetOperator service #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
|
/rebuild |
nolouch
added
the
needs-cherry-pick-release-2.1
disksing
approved these changes
Apr 8, 2019
rleungx
reviewed
Apr 8, 2019
| // NewOperatorRecords returns a OperatorRecords. | ||
| func NewOperatorRecords() *OperatorRecords { | ||
| return &OperatorRecords{ | ||
| ttl: cache.NewTTL(time.Minute, 10*time.Minute), |
There was a problem hiding this comment.
Should we make this parameter configurable?
There was a problem hiding this comment.
I think no need, just keep for a while.
server/schedule/mockcluster.go
Outdated
| region = region.Clone(core.WithAddPeer(peer)) | ||
| case PromoteLearner: | ||
| if region.GetStoreLearner(s.ToStore) == nil { | ||
| panic("promote peer that doesn't exist") |
There was a problem hiding this comment.
It will be better to keep the first letter consistent with other panic messages.
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
==========================================
+ Coverage 67.29% 67.43% +0.13%
==========================================
Files 158 158
Lines 15465 15518 +53
==========================================
+ Hits 10407 10464 +57
- Misses 4108 4113 +5
+ Partials 950 941 -9
Continue to review full report at Codecov.
|
rleungx
approved these changes
Apr 8, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Apr 22, 2019
* *: add GetOperator service Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Apr 23, 2019
* *: add GetOperator service Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The lightning needs to know the
scatter-regionoperator whether finished before import data.What is changed and how it works?
adds a gRPC service.
Check List
Tests