Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: supports scatter region and get operator status #1501

Merged
merged 5 commits into from
Apr 15, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 11, 2019

What problem does this PR solve?

Add the scatter region and get operator interface to PD Client.

Check List

Tests

  • Unit test

@nolouch nolouch requested review from disksing and rleungx April 11, 2019 09:26
@nolouch nolouch force-pushed the support-scatter branch 2 times, most recently from 91faafb to 8f8de63 Compare April 11, 2019 09:37
@nolouch
Copy link
Contributor Author

nolouch commented Apr 12, 2019

/rebuild

@crazycs520
Copy link
Contributor

@disksing @rleungx PTAL

nolouch added 2 commits April 15, 2019 16:56
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch force-pushed the support-scatter branch 2 times, most recently from 2a3d852 to 0ae6724 Compare April 15, 2019 09:03
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@656a830). Click here to learn what that means.
The diff coverage is 72.41%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1501   +/-   ##
========================================
  Coverage          ?   67.5%           
========================================
  Files             ?     158           
  Lines             ?   15550           
  Branches          ?       0           
========================================
  Hits              ?   10497           
  Misses            ?    4093           
  Partials          ?     960
Impacted Files Coverage Δ
client/client.go 68.99% <72.41%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656a830...d066cc0. Read the comment docs.

@disksing
Copy link
Contributor

no need metrics and tracing?

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Apr 15, 2019

@disksing PTAL

@disksing disksing merged commit fc997de into tikv:master Apr 15, 2019
@nolouch nolouch deleted the support-scatter branch April 15, 2019 11:16
nolouch added a commit to nolouch/pd that referenced this pull request Apr 23, 2019
* client: supports scatter region and get operator status

* imporve test

Signed-off-by: nolouch <nolouch@gmail.com>

* clean up

Signed-off-by: nolouch <nolouch@gmail.com>

* add metrics

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit that referenced this pull request Apr 23, 2019
* *: add GetOperator service (#1477)
* client: supports scatter region and get operator status (#1501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants