http/client, retry: copy a new Backoffer for each request #7684
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
status/LGT2
|
It would be good to add a race test |
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: fe5b3f3
|
ti-chi-bot
bot
added
the
status/can-merge
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
fix-backoffer-race
branch
from
fe5b3f3
to
3b3b3e0
Compare
ti-chi-bot
bot
added
size/XS
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 3b3b3e0
|
ti-chi-bot
bot
added
the
status/can-merge
ref tikv#7300 Copy a new `Backoffer` for each request to prevent race. Signed-off-by: JmPotato <ghzpotato@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>
ref tikv#7300 Copy a new `Backoffer` for each request to prevent race. Signed-off-by: JmPotato <ghzpotato@gmail.com>
What problem does this PR solve?
Issue Number: ref #7300, #7673.
What is changed and how does it work?
Check List
Tests
Release note