Add FileExists and DeleteFile to Env #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
BusyJay
reviewed
Dec 11, 2017
| SaveError(errptr, env->rep->FileExists(path)); | ||
| } | ||
|
|
||
| void crocksdb_env_delete_file(crocksdb_env_t* env, const char* path, char** errptr) { |
There was a problem hiding this comment.
Why delete it via Env? Why not just use fs::remove_file?
There was a problem hiding this comment.
Because file can be any kind of types, for example memory sst file.
There was a problem hiding this comment.
Can you provide a link to the explanation of memory SST file? Does it have a path?
There was a problem hiding this comment.
In RocksDB, Env is an interface to abstract some platform-dependent APIs.
For example, I can provide a MemEnv, which maintains a virtual file system in memory.
Then I can create a SstFileWriter with the MemEnv to generate SST file in memory.
Ref: https://github.com/facebook/rocksdb/blob/master/env/mock_env.h
yiwu-arbug
pushed a commit
that referenced
this pull request
Jun 4, 2020
update titan to include tikv/titan#169 for tikv-4.x include the following changes ``` 81814ec 2020-06-04 zbk602423539@gmail.. Fix GC may delete a already deleted blob file (#168) (#169) 80657c0 2020-06-04 zbk602423539@gmail.. Fix wrong assert delta < 0 for cocurrent compaction while flush (#172) (#176) 0db7976 2020-06-04 sre-bot@pingcap.com Fix wrong live data size when encounter rewrite failure (#161) (#175) c41f2a2 2020-06-04 sre-bot@pingcap.com feat: Titan should return user value to compaction filter #163 (#164) (#174) ``` Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.