-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS build #176
Fix macOS build #176
Conversation
.travis.yml
Outdated
@@ -12,6 +12,7 @@ cache: | |||
|
|||
os: | |||
- linux | |||
- osx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only stable compiler on OS X needs to be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@BusyJay PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
update titan to include tikv/titan#169 for tikv-4.x include the following changes ``` 81814ec 2020-06-04 zbk602423539@gmail.. Fix GC may delete a already deleted blob file (#168) (#169) 80657c0 2020-06-04 zbk602423539@gmail.. Fix wrong assert delta < 0 for cocurrent compaction while flush (#172) (#176) 0db7976 2020-06-04 sre-bot@pingcap.com Fix wrong live data size when encounter rewrite failure (#161) (#175) c41f2a2 2020-06-04 sre-bot@pingcap.com feat: Titan should return user value to compaction filter #163 (#164) (#174) ``` Signed-off-by: sre-bot <sre-bot@pingcap.com>
Also enabled macOS build on Travis CI to test it.