Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds VectorValueExt #4532

Closed
wants to merge 8 commits into from
Closed

Conversation

breezewish
Copy link
Member

Signed-off-by: Breezewish breezewish@pingcap.com

What have you changed? (mandatory)

VectorValueExt provides a generic way to push values into a VectorValue.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

No.

Signed-off-by: Breezewish <breezewish@pingcap.com>
@breezewish breezewish mentioned this pull request Apr 15, 2019
1 task
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/coprocessor/codec/data_type/vector.rs Show resolved Hide resolved
AndreMouche
AndreMouche previously approved these changes Apr 16, 2019
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

src/coprocessor/codec/data_type/vector.rs Outdated Show resolved Hide resolved
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breezewish breezewish force-pushed the ___batch_extract/t5/1 branch from 0ad614e to 6243533 Compare April 17, 2019 10:35
@breezewish
Copy link
Member Author

No need any more because #4533 is merged.

@breezewish breezewish closed this Apr 17, 2019
@breezewish breezewish deleted the ___batch_extract/t5/1 branch April 17, 2019 14:10
@breezewish breezewish restored the ___batch_extract/t5/1 branch April 17, 2019 14:10
@breezewish breezewish mentioned this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants