Batch aggregation framework #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
AndreMouche
reviewed
Apr 16, 2019
| fn test_type_match() { | ||
| /// A state that accepts Int and outputs Real. | ||
| #[derive(Clone, Debug)] | ||
| struct AggrFnStateFoo { |
There was a problem hiding this comment.
Could we implement an aggregation function directly in this PR as a sample so we needn't implement one in the test?
There was a problem hiding this comment.
I intentionally extracted them into different PRs because a fully functional aggr function implementation is not very short 🙃 For a real implementation, see
tikv/src/coprocessor/dag/aggr_fn/impl_avg.rs
Line 142 in ab507ab
AndreMouche
previously approved these changes
Apr 16, 2019
rleungx
reviewed
Apr 16, 2019
src/coprocessor/dag/aggr_fn/mod.rs
Outdated
| @@ -0,0 +1,361 @@ | |||
| // Copyright 2019 PingCAP, Inc. | |||
There was a problem hiding this comment.
Thanks for reminding!
Signed-off-by: Breezewish <breezewish@pingcap.com>
AndreMouche
approved these changes
Apr 17, 2019
rleungx
approved these changes
Apr 17, 2019
Closed
fredchenbj
pushed a commit
to fredchenbj/tikv
that referenced
this pull request
Apr 24, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
The framework for batch aggregations. See unit test for examples of how to write aggregate functions under this framework.
Extracted from #3898
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Unit test.