Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing addtestdep not defined #104

Closed
wants to merge 1 commit into from
Closed

Fixing addtestdep not defined #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SnoopCompileBot/src/botutils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ function pathof_noload(package_name::String)
end

################################################################

export addtestdep
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this. Use using SnoopCompileBot: addtestdep instead.

import Pkg
"""
Should be removed once Pkg allows adding test dependencies to the current environment
Expand Down
2 changes: 1 addition & 1 deletion docs/src/bot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
- name: Install dependencies
run: |
julia --project -e 'using Pkg; Pkg.instantiate();'
julia -e 'using Pkg; Pkg.add(PackageSpec(url = "https://github.com/timholy/SnoopCompile.jl")); Pkg.develop(PackageSpec(; path=pwd())); using SnoopCompile; SnoopCompile.addtestdep();'
julia -e 'using Pkg; Pkg.add(PackageSpec(url = "https://github.com/timholy/SnoopCompile.jl")); Pkg.develop(PackageSpec(; path=pwd())); using SnoopCompile; addtestdep();'
- name: Generating precompile files
run: julia --project -e 'include("deps/SnoopCompile/snoop_bot.jl")' # NOTE: must match path
- name: Running Benchmark
Expand Down
2 changes: 1 addition & 1 deletion src/SnoopCompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ end

using SnoopCompileBot
export BotConfig, snoop_bot, snoop_bench
export timesum, pathof_noload, GoodPath
export timesum, pathof_noload, GoodPath, addtestdep
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, definitely not!

if isdefined(SnoopCompileBot, Symbol("@snoopiBench"))
# deprecated names
export @snoopiBench, @snoopiBot, @snoopi_bench, @snoopi_bot
Expand Down