-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing addtestdep not defined #104
Conversation
This does not solve the issue, and I cannot run |
You just to say |
@@ -236,7 +236,7 @@ function pathof_noload(package_name::String) | |||
end | |||
|
|||
################################################################ | |||
|
|||
export addtestdep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do this. Use using SnoopCompileBot: addtestdep
instead.
@@ -20,7 +20,7 @@ end | |||
|
|||
using SnoopCompileBot | |||
export BotConfig, snoop_bot, snoop_bench | |||
export timesum, pathof_noload, GoodPath | |||
export timesum, pathof_noload, GoodPath, addtestdep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, definitely not!
#107 solves this |
In this new configuration, people cannot call the internal functions of each package through SnoopCompile.
We should probably use
@reexport
to solve this issue.