-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes (mostly for the split) #107
Conversation
I think we should restart the failed jobs. That was probably a connection issue. We can add this strategy:
fail-fast: false
matrix: |
Looks like doing the |
Instead of restarting, any additions you want? Might as well test those as the same time. |
I am testing this branch here: https://github.com/JuliaMusic/MusicXML.jl/actions?query=workflow%3ASnoopCompile |
This fails. Updating registry at `~/.julia/registries/General`
Updating git-repo `https://github.com/JuliaRegistries/General.git`
Resolving package versions...
ERROR: Unsatisfiable requirements detected for package SnoopCompileBot [1d5e0e55]:
SnoopCompileBot [1d5e0e55] log:
├─possible versions are: 1.6.0 or uninstalled
└─restricted to versions 1.6.1-1.6 by SnoopCompile [aa65fe97] — no versions left
└─SnoopCompile [aa65fe97] log:
├─possible versions are: 1.6.1 or uninstalled
└─SnoopCompile [aa65fe97] is fixed to version 1.6.1 This is about my point about JuliaLang/Pkg.jl#1874, which is why we should change all of the codes everywhere, instead of fixing it in one place (deps/build.jl). Now I need to change SnoopCompile.yml to test this branch! |
Packages shouldn't In other words, run MusicXML's scripts locally and see if they work. Don't change its script in the package. |
If that's it...I have a commit queued to add the |
I tested this on MusicXML locally and it works now. I made a dev script, which allows me to dev SnoopCompile for different environments quickly. |
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Also adds a clarification about sorting order in invalidations
Also switches to tilde bounds on package versions to be more restrictive.
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
This fixes a number of issues, most of which are leftovers from splitting the package and most of which only concern the docs. The
reason
change fixes a bug when invalidations stem from both method insertions and method deletions, and the Manifest.toml file is a workaround for JuliaLang/Pkg.jl#1874. We'll have to remember to update the Manifest before every PR, presumably, and I'm not sure it will be robust across Julia versions, but I think it's the best we can do for now.@aminya, if #105 is still an issue even after this, you may want to add some additional
using SnoopCompileBot: some_private_function
statements toSnoopCompile
, see the existing models. I'll wait for your comments on this before merging (feel free to submit a PR against this branch).