Support for extended Function keys F13 to F24 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I missed this, I can merge if you revert your namespacing. |
|
@timoxley Sure, let me undo those and rebase to a single commit so it's a little easier to work with, should the need to revert happen. |
|
@timoxley I modified the commits in this PR, but I don't have permission to close it outright. Instead, I created a new PR, #58, that makes the changes you requested, removes some of the stylistic changes introduced, and doesn't ignore CC @Galkon Josh, I think it kept most of your originally intended changes, but since I didn't see a test that was added for it, I'm testing it on Medal right now. |
One-liner: Added a variable declaration for our for...in loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for extended Function keys F13 to F24