deprecate MSWebdriver #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
force-pushed
the
deprecate_mswebdriver
branch
from
51a1346 to
de722f8
Compare
Closed
|
I think it is going to make more sense to just delete this class entirely for 3.9, so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not certain the current implementation of MSWebdriver works for Edge versions < 17, and I can't get any of my virtual machines to even run the Microsoft Webdriver, let alone validate that the webdrivers gem logic is working. So, I'd like to just deprecate this entire class for webdrivers 4, and then create a new one to support the new Chromium version for 4.0. Note that Selenium 4 will not work with Edge 17 & below.
Any objections to this approach?