Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.9 #94

Closed
wants to merge 10 commits into from
Closed

3.9 #94

wants to merge 10 commits into from

Conversation

titusfortner
Copy link
Owner

Ok, this is everything I think we need as a final 3.x release.
This might be a pain to review, but I tried to make each commit obvious and straightforward.

This is all dependent on the refactoring in #86, #90 & #91
Caching addresses #29 & #77
Direct downloading of geckodriver addresses #30

I've got cache time defaulting to zero, with the idea of making it default for 4.x. Or should we set a value for 3.9?

I'm thinking we release this and then for 4.0 we:

  1. Add the documentation
  2. Create the Rake Tasks
  3. Remove the deprecations
  4. Change default cache_time to 24 hours

@titusfortner
Copy link
Owner Author

Only thing left to evaluate is #104 so closing this.

@kapoorlakshya kapoorlakshya deleted the 3_9 branch June 4, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant