Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethers v5 as of release v2024.4.5 #244

Open
wants to merge 5 commits into
base: ethers-v5
Choose a base branch
from

Conversation

andrewkmin
Copy link
Collaborator

@andrewkmin andrewkmin commented Apr 12, 2024

Summary & Motivation

Merging into the ethers-v5 branch, which will be used to update our ethers v5 package in parallel with our new/current ethers v6-compatible package. The ethers-v5 branch is based off of 791bfe9, which is the current tip of main.

The plan is to merge this into ethers-v5, and then follow up with a separate PR to create the appropriate changeset.

Note: codesandbox is currently failling; may be due to rate limiting.

How I Tested These Changes

  • Unit
  • Examples [todo]

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

@andrewkmin andrewkmin force-pushed the andrew/ethers-v5-v2024-4-5 branch 2 times, most recently from 7e92186 to c7bd470 Compare April 12, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant