-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix get_private_key route; version bump and changelog #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably need a minor bump in @http
when this gets released. You can create a new changeset to declare your intent (similar to https://github.com/tkhq/sdk/blob/main/.changeset/extra-http-exports.md?plain=1)
can you give me the ELI5 on how |
The idea of the For example: a bug fix will have a changeset that says "bugfix". The changeset here is a "minor" version bump because we're adding new exports. At release time, the releaser will use the changesets in the
So basically, creating a changeset file doesn't do anything now; think of it as instructions for the person who will release a new SDK version in the future. |
bc4ff4d
to
de6344c
Compare
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: @turnkey/cosmjs@0.2.1, @turnkey/ethers@0.14.1, @turnkey/http@0.15.0 |
920028f
to
df769a2
Compare
|
||
/** | ||
* Get Private Key | ||
* | ||
* Get details about a Private Key | ||
* | ||
* `POST /tkhq/public/v1/query/get_private_key` | ||
* | ||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
never, | ||
never | ||
>({ | ||
uri: "/public/v1/query/get_private_key", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
Summary & Motivation
beta user found this bug 🐛
How I Tested These Changes
e2e