Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_private_key route; version bump and changelog #67

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

timurnkey
Copy link
Contributor

Summary & Motivation

beta user found this bug 🐛

How I Tested These Changes

e2e

Copy link
Contributor

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably need a minor bump in @http when this gets released. You can create a new changeset to declare your intent (similar to https://github.com/tkhq/sdk/blob/main/.changeset/extra-http-exports.md?plain=1)

@timurnkey
Copy link
Contributor Author

You'll probably need a minor bump in @http when this gets released. You can create a new changeset to declare your intent (similar to https://github.com/tkhq/sdk/blob/main/.changeset/extra-http-exports.md?plain=1)

can you give me the ELI5 on how .changeset works?

@r-n-o
Copy link
Contributor

r-n-o commented May 30, 2023

can you give me the ELI5 on how .changeset works?

The idea of the .changeset folder is to be used as a staging area for pending changesets. Each changeset is described in English, along with how it should affect the package versions when released.

For example: a bug fix will have a changeset that says "bugfix". The changeset here is a "minor" version bump because we're adding new exports.

At release time, the releaser will use the changesets in the .changeset folder, aggregate them, and produce:

  • a changelog
  • a new version for each package (e.g. if "minor bump for @http" and "bugfix bump for @http" are the two requirements, the version will be a minor bump)

So basically, creating a changeset file doesn't do anything now; think of it as instructions for the person who will release a new SDK version in the future.

@keyz-tk keyz-tk force-pushed the tim/fix-get-private-key-route branch from bc4ff4d to de6344c Compare June 1, 2023 22:12
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: @turnkey/cosmjs@0.2.1, @turnkey/ethers@0.14.1, @turnkey/http@0.15.0

@keyz-tk keyz-tk force-pushed the tim/fix-get-private-key-route branch from 920028f to df769a2 Compare June 1, 2023 22:18
@keyz-tk keyz-tk changed the title fix get_private_key route fix get_private_key route; version bump and changelog Jun 1, 2023

/**
* Get Private Key
*
* Get details about a Private Key
*
* `POST /tkhq/public/v1/query/get_private_key`
*
* @deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

never,
never
>({
uri: "/public/v1/query/get_private_key",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@moe-dev moe-dev mentioned this pull request Oct 18, 2024
This was referenced Oct 21, 2024
This was referenced Nov 13, 2024
@andrewkmin andrewkmin mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants