Andrew/import export upgrade #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
commented
Nov 4, 2024
| @@ -92,6 +96,57 @@ export class TurnkeyBrowserSDK { | |||
| }); | |||
| }; | |||
|
|
|||
| // With export and import, we do not call init() so that the caller can control when they'd like to insert the iframe into the DOM | |||
There was a problem hiding this comment.
while we could use a helper (or some mechanism) to manage export / import iframes, this isn't the best route.
andrewkmin
commented
Nov 4, 2024
| @@ -99,6 +123,31 @@ export const TurnkeyProvider: React.FC<TurnkeyProviderProps> = ({ | |||
| iframeElementId: TurnkeyAuthIframeElementId, | |||
| }); | |||
| setAuthIframeClient(newAuthIframeClient); | |||
|
|
|||
| // Optionally include import iframe | |||
| // Should allow specification (config) of container / element ID | |||
There was a problem hiding this comment.
not sure if this ultimately belongs here, in a provider that wraps an entire application
|
closing in favor of #416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.