add biconomy aa support to eth passkeys example #415
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
force-pushed
the
andrew/aa-passkeys-galore
branch
3 times, most recently
from
65e0014 to
b458056
Compare
andrewkmin
force-pushed
the
andrew/aa-passkeys-galore
branch
from
b458056 to
a9b7690
Compare
andrewkmin
requested review from
omkarshanbhag,
moe-dev,
zkharit and
taylorjdawson
| @@ -1,5 +1,13 @@ | |||
| # @turnkey/with-eth-passkey-signers | |||
|
|
|||
| ## 0.2.0 | |||
There was a problem hiding this comment.
this is primarily for tracking on our side. think a changelog would be helpful in keeping track of changes over time
| ) => Promise<BiconomySmartAccountV2>, | ||
| options?: { nonceOptions?: { nonceKey: number } } | ||
| ) => { | ||
| const { destinationAddress, amount } = data; |
There was a problem hiding this comment.
tiny nit: do we want to do any input validation?
There was a problem hiding this comment.
we should in a more serious application but will leave it out of this PR for now :)
| @@ -28,13 +28,20 @@ $ pnpm install # Install dependencies | |||
| $ pnpm run build # Compile source code | |||
| ``` | |||
|
|
|||
| ### 2/ Setting up Turnkey | |||
There was a problem hiding this comment.
Would be great to be more explicit about the two options of how to run this example in the README!!
It looks like we either do an AA based flow or a normal ETH signing flow based on whether or not NEXT_PUBLIC_BICONOMY_BUNDLER_URL and NEXT_PUBLIC_BICONOMY_PAYMASTER_API_KEY are set.
There was a problem hiding this comment.
Also a quick line on what Biconomy is and what functionality it adds to this example
| type signMessageFormData = { | ||
| messageToSign: string; | ||
| }; | ||
|
|
||
| type signTransactionFormData = { |
There was a problem hiding this comment.
nit: should we capitalize these types?
| @@ -366,6 +560,53 @@ export default function Home() { | |||
| </form> | |||
| </div> | |||
| )} | |||
| {wallet && ( | |||
| <div> | |||
| <h2>... and now let's sign a transaction!</h2> | |||
There was a problem hiding this comment.
maybe a little more readable
| <h2>... and now let's sign a transaction!</h2> | |
| <h2>... and now let{"'"}s sign a transaction!</h2> |
or even
<h2>... and now {"let's"} sign a transaction!</h2>
Summary & Motivation
$title
see changelog
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.