New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M3a] Sampling Primitives & Random Number Generator #421

Merged

junrushao merged 23 commits into tlc-pack:main from zxybazh:sampler

Aug 12, 2021

Collaborator

zxybazh commented Jul 30, 2021

This PR introduced new implementation of Random Number Generator & Sampler based on a int64_t pointer. The current design has better serialization & more friendly for ForkSeed function, while being reproducible.

zxybazh requested review from comaniac, jcf94, junrushao, Laurawly, merrymercy, tqchen, vinx13, were, yzhliu and ZihengJiang as code owners

July 30, 2021 00:58

zxybazh changed the title ~~[M3a] Sampler~~ [WIP][M3a] Sampler

Member

junrushao commented Jul 30, 2021

Please rebase

zxybazh closed this

Collaborator Author

zxybazh commented Jul 30, 2021

Rebased and still merging and testing with new updates on sampler class.

zxybazh reopened this

zxybazh changed the title ~~[WIP][M3a] Sampler~~ [M3a] Sampler & Random Number Generator

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

tests/cpp/meta_schedule_test.cc Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

tqchen reviewed

View reviewed changes

src/support/rng.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

include/tvm/support/random_engine.h Outdated Show resolved Hide resolved

Member

junrushao commented Aug 3, 2021

I am very excited about this PR, which paves the way for sampling instructions in our meta schedule DSL. Let's move fast and get it done on upstream by the end of this week

Collaborator Author

zxybazh commented Aug 5, 2021

Updated the random engine usage to be consistent with [Support] Linear Congruential Random Engine #8642
in main repo.

Member

junrushao commented Aug 7, 2021

Thank you so much @zxybazh! I am going to do another round

junrushao reviewed

View reviewed changes

src/tir/schedule/sampler.h Outdated Show resolved Hide resolved

zxybazh added 14 commits

August 10, 2021 18:30


          Change file name and add checks.

cb2158f


          Fix seed = -1 situation.

0ad9e26


          Update random engine usage.

b8e0d63


          Add new line.

bf27b94


          Change type and consistency.

8b3484f


          Change type.

9872d23


          Dissolve sampler & fix LCE.

ce582e7


          Fix rebase error.

6f3aed9


          Fix rpc tests.

caa109e


          Remove sampler comments.

0fffeec


          Fix seeding process.

015fda3


          Fix minor bug.

5974a1c


          Monir fix.

89fba27


          Make seed value consistent.

d9f8c16

zxybazh commented

View reviewed changes

Collaborator Author

zxybazh left a comment

Just self reviewed and passed tests. Please review, thanks!

junrushao reviewed

View reviewed changes

src/tir/schedule/primitive.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

tests/python/meta_schedule/test_integration_cuda.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

tests/python/meta_schedule/test_meta_schedule_layout_rewrite_network.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

tests/python/meta_schedule/test_resnet_end_to_end.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

tests/python/meta_schedule/test_resnet_end_to_end_cuda.py Outdated Show resolved Hide resolved

Member

junrushao commented Aug 12, 2021

overall looks good! let's move fast and get it merged

zxybazh added 3 commits

August 11, 2021 18:32


          Revoke test changes.

c38e52c


          Revoke more tests.

b220566


          Move prime table.

ca6aeef

Collaborator Author

zxybazh commented Aug 12, 2021

Fixed.

junrushao approved these changes

View reviewed changes

Member

junrushao commented Aug 12, 2021

Thanks @zxybazh for the effort!

junrushao merged commit 14632f0 into tlc-pack:main

Member

junrushao commented Aug 12, 2021

Please share the integration test errors in the github issue :-)

Collaborator Author

zxybazh commented Aug 12, 2021

Integration test errors shared in the github issue channel.
#436, #437, #438, #439, #440, #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tqchen tqchen left review comments

junrushao junrushao approved these changes

comaniac Awaiting requested review from comaniac comaniac is a code owner

jcf94 Awaiting requested review from jcf94

Laurawly Awaiting requested review from Laurawly

merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

vinx13 Awaiting requested review from vinx13 vinx13 is a code owner

were Awaiting requested review from were were is a code owner

yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

ZihengJiang Awaiting requested review from ZihengJiang ZihengJiang is a code owner

Labels

None yet